Skip to content

[SYCL][Graph] Refactor node storage inside graphs #11596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2023
Merged

[SYCL][Graph] Refactor node storage inside graphs #11596

merged 3 commits into from
Oct 24, 2023

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Oct 19, 2023 •
edited
Loading

  • Store graph nodes inside a vector for more optimal searches
  • Replace several depth first search operations with iterations over node storage
  • Node successors are now weak_ptrs
  • Unit tests updated to reflect changes

@Bensuo Bensuo temporarily deployed to WindowsCILock October 19, 2023 12:33 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock October 19, 2023 12:55 — with GitHub Actions Inactive
@Bensuo Bensuo force-pushed the ben/node-storage-refactor branch from 7e76217 to 62057ce Compare October 19, 2023 14:43
@Bensuo Bensuo temporarily deployed to WindowsCILock October 19, 2023 14:52 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock October 19, 2023 15:14 — with GitHub Actions Inactive
EwanC
EwanC reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicky comments, will take a closer look tomorrow

@Bensuo Bensuo temporarily deployed to WindowsCILock October 20, 2023 12:32 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock October 20, 2023 12:54 — with GitHub Actions Inactive
Bensuo added 3 commits October 23, 2023 15:02
@Bensuo
[SYCL][Graph] Refactor node storage inside graphs
5501907 
- Store graph nodes inside a vector for more optimal search
- Replace several depth first search operations with iterations over node storage
- Node successors are now weak_ptrs
- Remove node_impl::operator== and move functionality to isSimilar()
- Unit tests updated to reflect changes
@Bensuo
Addressing PR comments
508ee90
@Bensuo
[SYCL][Graph] Addressing PR feedback
c9cfc73 
- Style fixes
- Make MRoots weak_ptrs instead of shared
@Bensuo Bensuo force-pushed the ben/node-storage-refactor branch from 2da28fb to c9cfc73 Compare October 23, 2023 14:02
@Bensuo Bensuo temporarily deployed to WindowsCILock October 23, 2023 14:04 — with GitHub Actions Inactive
@Bensuo Bensuo temporarily deployed to WindowsCILock October 23, 2023 14:27 — with GitHub Actions Inactive
@Bensuo Bensuo mentioned this pull request Oct 24, 2023
Closed
@Bensuo Bensuo marked this pull request as ready for review October 24, 2023 13:48
@Bensuo Bensuo requested a review from a team as a code owner October 24, 2023 13:48
@againull againull merged commit 67a81f6 into intel:sycl Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bensuo @EwanC @againull