[SYCL][Graph] Reenable passing Graph tests on Arc #11602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following 13 graphs tests now pass on the Arc post commit testing after the merge of intel#11565 ``` Unexpectedly Passed Tests (13): SYCL :: Graph/Explicit/basic_buffer.cpp SYCL :: Graph/Explicit/buffer_copy_host2target.cpp SYCL :: Graph/Explicit/buffer_copy_host2target_2d.cpp SYCL :: Graph/Explicit/buffer_copy_host2target_offset.cpp SYCL :: Graph/Explicit/temp_buffer_reinterpret.cpp SYCL :: Graph/Explicit/usm_copy.cpp SYCL :: Graph/RecordReplay/basic_buffer.cpp SYCL :: Graph/RecordReplay/buffer_copy_host2target.cpp SYCL :: Graph/RecordReplay/buffer_copy_host2target_2d.cpp SYCL :: Graph/RecordReplay/buffer_copy_host2target_offset.cpp SYCL :: Graph/RecordReplay/temp_buffer_reinterpret.cpp SYCL :: Graph/RecordReplay/usm_copy.cpp SYCL :: Graph/RecordReplay/usm_copy_in_order.cpp ``` There are some Graphs E2E tests which are still marked XFAIL on Arc, but the same subset failed(via XPASS) in two post-commit runs: * https://github.com/intel/llvm/actions/runs/6576278057/job/17865822384 * https://github.com/intel/llvm/actions/runs/6572360130/job/17855217912
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Oct 20, 2023
PR intel#11602 renabled some Graph test-e2e tests which started passing on Arc in post-commit CI. However, these passes are guaranteed to be deterministic. See post-commit https://github.com/intel/llvm/actions/runs/6580530144/job/17879085527 run where `Graph/RecordReplay/buffer_copy_host2target_offset.cpp` failed. Mark the reenabled tests as unsupported to keep post-commit CI clean, until support for the Arc target can be investigated properly.
againull
pushed a commit
that referenced
this pull request
Oct 20, 2023
PR #11602 renabled some Graph test-e2e tests which started passing on Arc in post-commit CI after the merge of #11565. However, these passes are not guaranteed to be deterministic. See post-commit https://github.com/intel/llvm/actions/runs/6580530144/job/17879085527 run where `Graph/RecordReplay/buffer_copy_host2target_offset.cpp` failed after being renabled. Mark the tests reenabled by #11602 as unsupported to keep post-commit CI clean by skipping the tests on Arc, until support for the Arc target in the Graph tests can be investigated properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following 13 graphs tests originally disabled by #11434 now pass on the Arc post commit testing after the merge of #11565
There are some Graphs E2E tests which are still marked XFAIL on Arc, but the same subset failed(via XPASS) in two post-commit runs: