[SYCL] Bump SYCL_MINOR_VERSION #11605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should have done it much earlier, but better late than never.
aelovikov-intel
requested review from
cperkinsintel,
AlexeySachkov,
steffenlarsen and
stdale-intel
stdale-intel
approved these changes
Oct 19, 2023
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
There was a problem hiding this comment.
If it is not corresponding to a release with release notes, shouldn't it be the SYCL_PATCH_VERSION we are changing? My understanding was that Major bumps were breaking releases, minor was non-breaking releases, and patch was anything outside releases that needed versioning.
We forgot to bump it with the last release, this is just a late bump. |
steffenlarsen
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have done it much earlier, but better late than never.