Skip to content

[SYCL] Refine annotated_ptr address space based on compile-time USM kind #11623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

wangdi4
Copy link
Contributor

@wangdi4 wangdi4 commented Oct 23, 2023

Right now the annotated_ptr extension applies compile-time properties on decorated_global_ptr for SYCL device code. As the SYCL extension sycl_ext_oneapi_usm_malloc_properties introduces compile-time property "usm_kind"(implemented in #10235 ), this PR further refines the address space of this pointer (using decorated_device_ptr or decorated_host_ptr) when

  1. usm_kind property is specified in annotated_ptr type, and
  2. both __SYCL_DEVICE_ONLY__ and __ENABLE_USM_ADDR_SPACE__ are turned on (i.e. requiring compiler flags "-fsycl-device-only -fsycl-targets=spir64_fpga")

Other changes:

  • move annotated_ptr.hpp out from annotated_arg file into a separate folder
  • add new header file annotated_ptr_properties.hpp for annotated_ptr specific properties

@wangdi4 wangdi4 requested a review from a team as a code owner October 23, 2023 11:36
@wangdi4 wangdi4 requested a review from bso-intel October 23, 2023 11:36
@wangdi4 wangdi4 temporarily deployed to WindowsCILock October 23, 2023 12:46 — with GitHub Actions Inactive
@wangdi4 wangdi4 temporarily deployed to WindowsCILock October 24, 2023 14:25 — with GitHub Actions Inactive
@wangdi4 wangdi4 temporarily deployed to WindowsCILock October 24, 2023 14:49 — with GitHub Actions Inactive
@wangdi4
Copy link
Contributor Author

wangdi4 commented Oct 24, 2023

@bso-intel could you help review this PR?

@againull
Copy link
Contributor

@wangdi4 If I get it right, this PR contains changes from #10235 and some additional changes on top of it. So, should it be committed after #10235? If yes, then please turn this into draft so that it doesn't get merged and make it ready for review after #10235 is merged.

@wangdi4 wangdi4 marked this pull request as draft October 25, 2023 11:00
@wangdi4 wangdi4 temporarily deployed to WindowsCILock October 30, 2023 11:38 — with GitHub Actions Inactive
@wangdi4 wangdi4 temporarily deployed to WindowsCILock October 30, 2023 12:07 — with GitHub Actions Inactive
@wangdi4 wangdi4 marked this pull request as ready for review November 3, 2023 19:42
@againull againull merged commit 15e81fa into intel:sycl Nov 6, 2023
againull pushed a commit that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants