[SYCL][ESIMD] Add more stringent compile time checks to local_accessor version of block_load/block_store, gather/scatter API #11653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock_load/block_store, gather/scatter API
v-klochkov
reviewed
Oct 26, 2023
|
|
||
| // Incompatible mode (read). | ||
| SYCL_EXTERNAL void | ||
| kernel6(local_accessor<const int, 1> &buf) SYCL_ESIMD_FUNCTION { |
There was a problem hiding this comment.
'const int' means it is read only. It is surprising that SYCL implementation allowed creating it because
a) it is odd to have read-only local accessor - that memory cannot be written and thus is not usable
b) SYCL 2020 SPEC says: "This specialization of accessor is only available for access modes access_mode::read_write and access_mode::atomic.".
v-klochkov
reviewed
Oct 26, 2023
| simd<int, 32> v(0, 1); | ||
| // CHECK: block_load_store.cpp:57{{.*}}error: no matching function | ||
| // function for call to 'block_store' | ||
| block_store<int, 32>(buf, 0, v); |
There was a problem hiding this comment.
kernel1() in this test is the only positive test for load/store for read/write accessor.
Wouldn't it be useful to add 2 more cases - 1 load from read accesor and 1 store to write accessor?
v-klochkov
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.