[SYCL][Bindless] Change the name of map_external_memory_array
#11681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap_external_image_memory` * The original name map_external_memory_array was chosen as when mapping external memory in the CUDA backend, we mapped to a CUarray object. * This is not an ideal name, and doesn't best reflect the functionality of map_external_memory_array, especially once we map external memory in different backends.
cppchedy
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cppchedy
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
isaacault
approved these changes
Oct 27, 2023
Seanst98
approved these changes
Oct 27, 2023
przemektmalon
approved these changes
Oct 27, 2023
DBDuncan
approved these changes
Oct 27, 2023
aelovikov-intel
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the name of
map_external_memory_arraytomap_external_image_memoryThe original name map_external_memory_array was chosen as when mapping external memory in the CUDA backend, we mapped to a CUarray object.
This is not an ideal name, and doesn't best reflect the functionality of map_external_memory_array, especially once we map external memory in different backends.