Skip to content

[NFC]Use Cast instead of dyn_cast in X86PreAMXConfig.cpp #11686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[NFC]Use Cast instead of dyn_cast in X86PreAMXConfig.cpp #11686

wants to merge 1 commit into from

Conversation

XinWang10
Copy link
Contributor

@XinWang10 XinWang10 commented Oct 27, 2023 •
edited
Loading

If we can reach the line 291, then we must have reached line 280 'PosEnd = I', so PosEnd must be type IntrinsicInst.

@XinWang10 XinWang10 requested a review from a team as a code owner October 27, 2023 08:27
@XinWang10 XinWang10 changed the title [NFC]Use Cast instead dyn_cast in X86PreAMXConfig.cpp [NFC]Use Cast instead of dyn_cast in X86PreAMXConfig.cpp Oct 27, 2023
@XinWang10 XinWang10 temporarily deployed to WindowsCILock October 27, 2023 08:53 — with GitHub Actions Inactive
@AlexeySachkov
Copy link
Contributor

Shouldn't this go directly to llvm/llvm-project?

@XinWang10
Copy link
Contributor Author

Shouldn't this go directly to llvm/llvm-project?
This issue is reported by our internal static analyzer, and seems this file is not in llvm-project repo.

@yubingex007-a11y
Copy link
Contributor

can we cherry-pick llvm/llvm-project#69569?

@XinWang10
Copy link
Contributor Author

can we cherry-pick llvm/llvm-project#69569?
Wow. So I was curious why there is not a corresponding one in community, thanks for information. That's the correct action.

@XinWang10 XinWang10 closed this Oct 27, 2023
@XinWang10 XinWang10 temporarily deployed to WindowsCILock October 27, 2023 09:53 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubingex007-a11y yubingex007-a11y Awaiting requested review from yubingex007-a11y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XinWang10 @AlexeySachkov @yubingex007-a11y