Skip to content

[SYCL][libdevice] Add fp32 and fp64 division with rounding mode supported in kernel code #11704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Oct 30, 2023

This PR adds:
fdiv_rd, fdiv_rn, fdiv_ru, fdiv_rz, ddiv_rd, ddiv_rn, ddiv_ru, ddiv_rz into imf libdevice which implements fp32/64 division with rounding mode supported in sycl kernel code.

@jinge90 jinge90 requested review from a team as code owners October 30, 2023 03:34
@jinge90 jinge90 requested a review from bso-intel October 30, 2023 03:34
@jinge90 jinge90 temporarily deployed to WindowsCILock October 30, 2023 03:36 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock October 30, 2023 04:24 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Oct 30, 2023

Hi, @zettai-reido , @akolesov-intel
Could you help review this patch?
Thanks very much.

Copy link
Contributor

@maksimsab maksimsab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools part LGTM

Copy link

@xtian-github xtian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@againull againull merged commit 9c07b46 into intel:sycl Oct 30, 2023
maarquitos14 pushed a commit that referenced this pull request Oct 31, 2023
…rted in kernel code (#11704)

This PR adds:
fdiv_rd, fdiv_rn, fdiv_ru, fdiv_rz, ddiv_rd, ddiv_rn, ddiv_ru, ddiv_rz
into imf libdevice which implements fp32/64 division with rounding mode
supported in sycl kernel code.

Signed-off-by: jinge90 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants