Skip to content

[SYCL] Change vec::operator! to match SYCL spec #11750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 23, 2023

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Nov 1, 2023

Table 143 of the SYCL 2020 specification states that the return for the ! operator can be a different vector type. This change implements the interface described in the specification. Fixes #11659.

Table 143 of the SYCL 2020 specification states that the return for the
`!` operator can be a different vector type. This change implements the
interface described in the specification.

Signed-off-by: Michael Aziz <[email protected]>
@0x12CC 0x12CC temporarily deployed to WindowsCILock November 1, 2023 21:10 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to WindowsCILock November 1, 2023 22:32 — with GitHub Actions Inactive
@0x12CC 0x12CC marked this pull request as ready for review November 22, 2023 20:31
@0x12CC 0x12CC requested a review from a team as a code owner November 22, 2023 20:31
@0x12CC 0x12CC requested a review from steffenlarsen November 22, 2023 20:31
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit 7868596 into intel:sycl Nov 23, 2023
@0x12CC 0x12CC deleted the vec_op_not branch November 23, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vec::operator! has wrong return type
3 participants