Skip to content

[SYCL] Add rcp for fp32 and fp64 with rounding mode supported #11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Nov 3, 2023

This PR adds frcp_rd/n/u/z and drcp_rd/n/u/z to sycl::ext::intel::math which corresponds to CUDA math's __frcp_r* and __drcp_r*

@jinge90 jinge90 requested a review from a team as a code owner November 3, 2023 05:50
@jinge90 jinge90 requested a review from bso-intel November 3, 2023 05:50
@jinge90
Copy link
Contributor Author

jinge90 commented Nov 3, 2023

Hi, @zettai-reido @akolesov-intel @xtian-github
Could you help review this PR?
Thanks very much.

Copy link

@akolesov-nv akolesov-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to map rcp to existing div implementations with rounding

Copy link

@xtian-github xtian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinge90 jinge90 requested a review from a team November 6, 2023 08:02
@jinge90
Copy link
Contributor Author

jinge90 commented Nov 6, 2023

Hi, @intel/llvm-gatekeepers
Could you help merge this patch?
Thanks very much.

@steffenlarsen steffenlarsen merged commit 9a4719b into intel:sycl Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants