Skip to content

[SYCL] Add documentation and change default val for min range x to enable range rounding #11823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Nov 8, 2023

Some users found that 1024 was too conservative a min X dim to enable range rounding. This lowers that val.

It also adds some documentation for SYCL range rounding, which had been missing. Perhaps this should be in its own file. Let me know where to put it and I will do so.

Ping @DuncanMcBain

@hdelan hdelan requested review from a team as code owners November 8, 2023 17:16
@hdelan hdelan requested a review from cperkinsintel November 8, 2023 17:16
@hdelan
Copy link
Contributor Author

hdelan commented Nov 15, 2023

@bader any further comments? Do you think I should put this documentation in a different place or is EnvironmentVariables.md OK?

@bader
Copy link
Contributor

bader commented Nov 15, 2023

Do you think I should put this documentation in a different place or is EnvironmentVariables.md OK?

I would move the first section to a separate document in design directory and put a link to it in EnvironmentVariables.md. The second section describing environment variables belongs to EnvironmentVariables.md 👍.

Is SYCL_PARALLEL_FOR_RANGE_ROUNDING_PARAMS supported by the implementation? If no, we probably should state that explicitly. EnvironmentVariables.md is part of the "User documentation" and we might create wrong expectations from our users.

@hdelan hdelan force-pushed the range-rounding-documentation branch from b51391f to be3874a Compare November 16, 2023 08:50
@hdelan
Copy link
Contributor Author

hdelan commented Nov 16, 2023

I would move the first section to a separate document in design directory and put a link to it in EnvironmentVariables.md. The second section describing environment variables belongs to EnvironmentVariables.md 👍.

Done.

Is SYCL_PARALLEL_FOR_RANGE_ROUNDING_PARAMS supported by the implementation? If no, we probably should state that explicitly. EnvironmentVariables.md is part of the "User documentation" and we might create wrong expectations from our users.

Yes this is supported and works in DPC++ at the moment.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdelan, please, add new document to https://github.com/intel/llvm/blob/sycl/sycl/doc/index.rst to fix the Doxygen documentation build.

@hdelan
Copy link
Contributor Author

hdelan commented Nov 16, 2023

Thanks, change made

@hdelan
Copy link
Contributor Author

hdelan commented Nov 16, 2023

@bader checks now passing so I think this is good to go

@bader
Copy link
Contributor

bader commented Nov 16, 2023

@cperkinsintel, @intel/llvm-reviewers-runtime, please, approve to unblock the merge.

Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit b334e1a into intel:sycl Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants