-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Add documentation and change default val for min range x to enable range rounding #11823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bader any further comments? Do you think I should put this documentation in a different place or is |
I would move the first section to a separate document in Is |
b51391f
to
be3874a
Compare
Done.
Yes this is supported and works in DPC++ at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdelan, please, add new document to https://github.com/intel/llvm/blob/sycl/sycl/doc/index.rst to fix the Doxygen documentation build.
Thanks, change made |
@bader checks now passing so I think this is good to go |
@cperkinsintel, @intel/llvm-reviewers-runtime, please, approve to unblock the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some users found that 1024 was too conservative a min X dim to enable range rounding. This lowers that val.
It also adds some documentation for SYCL range rounding, which had been missing. Perhaps this should be in its own file. Let me know where to put it and I will do so.
Ping @DuncanMcBain