[SYCL][ESIMD] Unified memory API: atomic_update(usm_ptr, ...) #11862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turinevgeny
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
turinevgeny
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
v-klochkov
reviewed
Nov 13, 2023
sycl/test-e2e/ESIMD/unified_memory_api/atomic_update_usm_pvc_cmpxchg.cpp
Outdated
Show resolved
Hide resolved
v-klochkov
reviewed
Nov 13, 2023
v-klochkov
reviewed
Nov 13, 2023
sarnex
reviewed
Nov 13, 2023
turinevgeny
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
v-klochkov
approved these changes
Nov 14, 2023
turinevgeny
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
turinevgeny
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
turinevgeny
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
turinevgeny
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
v-klochkov
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
The additional changes look good. Thank you.
@sarnex - please confirm if you are Ok with the current changes.
sarnex
approved these changes
Nov 14, 2023
Comment on lines
+3506
to
+3509
| if constexpr (L1Hint != cache_hint::none || L2Hint != cache_hint::none || | ||
| (Op == atomic_op::fmin) || (Op == atomic_op::fmax) || | ||
| (Op == atomic_op::fadd) || (Op == atomic_op::fsub) || | ||
| !__ESIMD_DNS::isPowerOf2(N, 32)) { |
There was a problem hiding this comment.
Thanks, this is a lot easier to understand!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For one and two source API variants.