Skip to content

[SYCL] Fix strict alias violations in vec representation #11883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

steffenlarsen
Copy link
Contributor

@steffenlarsen steffenlarsen commented Nov 14, 2023

Parts of the vector implementation violates strict aliasing by representing vectors of certain types by another element type and reinterpret-casting to the right type to correctly pass references along. This may especially affect fundamental integral types that are not the default fixed-width integer type of the system.

Parts of the vector implementation violates strict aliasing by
representing vectors of certain types by another element type and
reinterpret-casting to the right type to correctly pass references
along. This may especially affect fundamental integral types that do are
not the default fixed-width integer type of the system.

Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Nov 14, 2023

This may especially affect fundamental integral types that do are not the default fixed-width integer type of the system.

@steffenlarsen steffenlarsen marked this pull request as ready for review November 16, 2023 08:31
@steffenlarsen steffenlarsen requested a review from a team as a code owner November 16, 2023 08:31
@steffenlarsen
Copy link
Contributor Author

Testing is covered by SYCL-CTS.

@steffenlarsen steffenlarsen merged commit a9d0e1b into intel:sycl Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants