[SYCL] Do not make auto& range parallel_for a future breaking change #11897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #ifndef PREVIEW_BREAKING_CHANGES | ||
| // For backwards compatibility, we still support some invalid variants of | ||
| // kernel lambdas. These test cases should be removed once we make conformant | ||
| // mode the default. |
There was a problem hiding this comment.
I'm confused. The comment here says that we still support invalid variants and hides the tests behind the #ifndef .
But here you are removing the guards and just running the tests. So these variants are not invalid?
There was a problem hiding this comment.
Strictly speaking, they are invalid according to the current wording of SYCL 2020 spec. However, we have received feedback from @gmlueck that in this case we would like to lift the spec restrictions instead of breaking existing code
There was a problem hiding this comment.
We actually think this is a bug in the spec, and the spec should allow "auto &". I have a TODO task to propose a PR that changes the spec.
AlexeySachkov
approved these changes
Nov 20, 2023
dm-vodopyanov
approved these changes
Nov 27, 2023
cperkinsintel
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.