Skip to content

[Opaque pointer] Recover ARM changes #11906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

[Opaque pointer] Recover ARM changes #11906

merged 1 commit into from
Nov 16, 2023

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Nov 16, 2023 •
edited
Loading

Fix #11905

@jsji jsji requested a review from a team as a code owner November 16, 2023 04:39
@jsji jsji self-assigned this Nov 16, 2023
@jsji jsji mentioned this pull request Nov 16, 2023
Closed
maksimsab
maksimsab approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@maksimsab maksimsab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered how we missed this change from community.
Looks like we lost only a small piece. I am OK to get it aligned with community.

@jsji
Copy link
Contributor Author

jsji commented Nov 16, 2023

I wondered how we missed this change from community. Looks like we lost only a small piece. I am OK to get it aligned with community.

Thanks @maksimsab
There were complications when dealing with opaque pointer -- we reverted many commits, but we can't simply revert them back later because of the code changes after revert, so we have to manually sync the code when we do the opaque pointer clean up. ARM was not built/tested by default, so we missed this.

@jsji
Copy link
Contributor Author

jsji commented Nov 16, 2023

@intel/llvm-gatekeepers Can we get this merged? Thanks.

@steffenlarsen steffenlarsen merged commit 481b436 into intel:sycl Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksimsab maksimsab maksimsab approved these changes

Assignees

@jsji jsji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation for ARM target fails because there is still a non-opaque pointer API in use
3 participants
@jsji @maksimsab @steffenlarsen