Skip to content

[SYCL] Enable loading cl_intel_devicelib_assert fallback spv #12009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Nov 27, 2023

Previously, we disabled cl_intel_devicelib_assert fallback spv in #6176 to bypass a Clang FE issue which existed in legacy compiler.
Now, the legacy compiler is out of date, we don't need this workaround any more, so enable loading cl_intel_devicelib_assert fallback spv again. This PR also updates some comments in sycl-post-link.

Previously, we disabled cl_intel_devicelib_assert fallback spv in
intel#6176 to bypass a Clang FE issue
which existed in legacy compiler.
Now, the legacy compiler is out of date, we don't need this workaround
any more, so enable loading cl_intel_devicelib_assert fallback spv again.
This PR also updates some comments in sycl-post-link.

Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 requested review from a team as code owners November 27, 2023 06:15
@jinge90 jinge90 requested a review from maarquitos14 November 27, 2023 06:15
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl-post-link change is non-functional, LGTM

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime change look good to me.

@jinge90 jinge90 requested a review from a team December 1, 2023 04:21
@jinge90
Copy link
Contributor Author

jinge90 commented Dec 1, 2023

Hi, @intel/llvm-gatekeepers
Could you help merge this patch? AWS CUDA test failed but it looks like to be environment issue:

" Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy'
nvidia-container-cli: requirement error: unsatisfied condition: cuda>=12.1, please update your driver to a newer version, or use an earlier cuda container: unknown
Error: failed to start containers: cdf8a38d2343157c9867734eccc3c893063ba40d99fa4887681d2d1640b074bc
Error: Docker start fail with exit code 1"
Hi, @tfzhu could you confirm whether the AWS CUDA failure is caused by environment error?
Thanks very much.

@tfzhu
Copy link
Contributor

tfzhu commented Dec 1, 2023

Hi, @intel/llvm-gatekeepers Could you help merge this patch? AWS CUDA test failed but it looks like to be environment issue:

" Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy' nvidia-container-cli: requirement error: unsatisfied condition: cuda>=12.1, please update your driver to a newer version, or use an earlier cuda container: unknown Error: failed to start containers: cdf8a38d2343157c9867734eccc3c893063ba40d99fa4887681d2d1640b074bc Error: Docker start fail with exit code 1" Hi, @tfzhu could you confirm whether the AWS CUDA failure is caused by environment error? Thanks very much.

Need to check with @aelovikov-intel. Re-run also failed.

@aelovikov-intel
Copy link
Contributor

Yes, looks like all our cuda aws testing is broken. No idea why...

@jinge90
Copy link
Contributor Author

jinge90 commented Dec 8, 2023

Hi, @intel/llvm-gatekeepers
Could you help merge this patch?
Thanks very much.

@aelovikov-intel aelovikov-intel merged commit 36fb61c into intel:sycl Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants