-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Enable loading cl_intel_devicelib_assert fallback spv #12009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Enable loading cl_intel_devicelib_assert fallback spv #12009
Conversation
Previously, we disabled cl_intel_devicelib_assert fallback spv in intel#6176 to bypass a Clang FE issue which existed in legacy compiler. Now, the legacy compiler is out of date, we don't need this workaround any more, so enable loading cl_intel_devicelib_assert fallback spv again. This PR also updates some comments in sycl-post-link. Signed-off-by: jinge90 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sycl-post-link
change is non-functional, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runtime change look good to me.
Hi, @intel/llvm-gatekeepers " Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error running hook #0: error running hook: exit status 1, stdout: , stderr: Auto-detected mode as 'legacy' |
Need to check with @aelovikov-intel. Re-run also failed. |
Yes, looks like all our cuda aws testing is broken. No idea why... |
Hi, @intel/llvm-gatekeepers |
Previously, we disabled cl_intel_devicelib_assert fallback spv in #6176 to bypass a Clang FE issue which existed in legacy compiler.
Now, the legacy compiler is out of date, we don't need this workaround any more, so enable loading cl_intel_devicelib_assert fallback spv again. This PR also updates some comments in sycl-post-link.