[SYCL] Don't zero-initialize MImageObj in 1.2.1 image #12012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
image_accessor constructor was generating following IR in O0 mode:
```
store target("spirv.Image", void, 0, 0, 0, 0, 0, 0, 1) zeroinitializer, ptr %0, align 8
```
As a target extension type, spirv.Image currently allows zeroinit.
However, OpConstantNull in spirv spec doesn't allows image type.
Therefore, we're not able to get sycl 1.2.1 image working in O0 mode.
This PR solves the issue by not initializing MImageObj.
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MrSidims
reviewed
Nov 30, 2023
| @@ -924,7 +924,7 @@ class image_accessor | |||
|
|
|||
| #ifdef __SYCL_DEVICE_ONLY__ | |||
| // Default constructor for objects later initialized with __init member. | |||
| image_accessor() : MImageObj() {} | |||
| image_accessor() {} | |||
There was a problem hiding this comment.
tbh can be even removed/defaulted in this case
MrSidims
approved these changes
Nov 30, 2023
|
@intel/llvm-gatekeepers Can we please merge this change? Thanks |
steffenlarsen
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image_accessor constructor was generating following IR in O0 mode:
As a target extension type, spirv.Image currently allows zeroinit.
However, OpConstantNull in spirv spec doesn't allow image type.
Therefore, we're not able to get sycl 1.2.1 image working in O0 mode.
This PR solves the issue by not initializing MImageObj.