[opencl-aot] Fix regression in error reporting #12022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a regression in error reporting, previously compiler build log was printed to `std::cerr`, but now it doesn't print by default. It makes it difficult for developers to understand what's going on. So now the compiler build log is printed to `std::cerr` if there is an error message, and to verbose logs if compilation was successful but there is something in the compiler build logs.
AlexeySachkov
approved these changes
Nov 28, 2023
dm-vodopyanov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dm-vodopyanov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a regression in error reporting, previously compiler build log was printed to
std::cerr, but now it doesn't print by default. It makes it difficult for developers to understand what's going on. So now the compiler build log is printed tostd::cerrif there is an error message, and to verbose logs if compilation was successful but there is something in the compiler build logs.