[SYCL] [NATIVECPU] Disabling default -sycl-opt for NativeCPU and updating docs
#12025
Conversation
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
There was a problem hiding this comment.
Docs changes LGTM! Maybe I just don't see the relation, but could this have been two PRs, i.e. one for -sycl-opt and one for the docs changes? If yes, we should aim for having that in the future. It makes the history cleaner and the discussion in the PR can be kept focused.
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
|
||
| // checking that explicitly enabling -sycl-opt still works | ||
| // RUN: %clang -fsycl -fsycl-targets=native_cpu -mllvm -sycl-opt -### %s 2>&1 | FileCheck -check-prefix=CHECK-OPT_ON %s | ||
| // CHECK-OPT_ON: -sycl-opt |
There was a problem hiding this comment.
This check doesn't make sense to me. We already have tests checking testing -mllvm option and I don't think this test adds any value.
There was a problem hiding this comment.
I removed the check. Thank you.
Yes, sorry, these could have been separate PRs, and I'll bare that in mind. Thank you. |
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hello @intel/llvm-gatekeepers , this PR looks ready to merge. Thank you! |
This PR no longer passes
-mllvm -sycl-optto the device compiler invocation for NativeCPU to enable the original full llvm optimization pipeline.EnvironmentVariables.mdhas been updated to document NativeCPU and its usage in environment variables.