[SYCL][NFC] Optimize int-convert.cpp test #12043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test sporadically timed out on Windows because default implicit context is disabled in there. Due to the fact that separate `queue` object was create for every kernel, it caused full re-JIT of the whole device code. Refactored the test to use a single queue object explicitly to have context and all associated caches to be shared between all kernels in the test. This resolves intel#12011
AlexeySachkov
changed the title
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Nov 30, 2023
|
CI on CUDA failed because machine lost connection to the server - I will proceed with the merge, because the change is trivial enough for that. As an indication that the test is actually quick on Windows now you can see logs from e2e tests: Comparing to another (randomly chosen) run of Windows e2e tests in pre-commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test sporadically timed out on Windows because default implicit context is disabled in there.
Due to the fact that separate
queueobject was create for every kernel, it caused full re-JIT of the whole device code.Refactored the test to use a single queue object explicitly to have context and all associated caches to be shared between all kernels in the test.
This resolves #12011