[SYCL][Doc] Add sycl_ext_oneapi_raw_kernel_arg #12098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft of an extension allowing opaque types to be passed to kernels via their raw byte representation. Signed-off-by: John Pennycook <[email protected]>
Pennycook
added
spec extension
jbrodman
approved these changes
Dec 6, 2023
gmlueck
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Thanks for writing this up, @Pennycook. Some comments below.
sycl/doc/extensions/proposed/sycl_ext_oneapi_raw_kernel_arg.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_raw_kernel_arg.asciidoc
Outdated
Show resolved
Hide resolved
Signed-off-by: John Pennycook <[email protected]>
gmlueck
reviewed
Dec 6, 2023
sycl/doc/extensions/proposed/sycl_ext_oneapi_raw_kernel_arg.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_raw_kernel_arg.asciidoc
Outdated
Show resolved
Hide resolved
gmlueck
approved these changes
Dec 7, 2023
steffenlarsen
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of an extension allowing opaque types to be passed to kernels via their raw byte representation.