-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][ESIMD][E2E] Add DG2 unified memory block_store tests #12100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
@@ -5,6 +5,9 @@ | |||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
// | |||
//==----------------------------------------------------------==// | |||
// TODO: Enable after driver bug is fixed | |||
// XFAIL: gpu-intel-dg2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIR, such params are not set in SYCLOS. gpu-intel-dg2 is always false there.
Perhaps, something in SYCLOS CI has changed and param is set - let's see how Intel Arg CI bot runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think you are right, I think this will fail in postcomit.
It seems we set gpu-intel-dg2=True
for the precommit Arc Matrix test job, but not for postcommit. I'll try to fix the CI before merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was wrong. We do set it for postcommit here. I think this PR is safe to merge.
@intel/llvm-gatekeepers Can we merge this one? It The Arc precommit job won't run the new tests added here anyway, they will only run in postcommit and I am convinced it will pass based on local testing and checking the flags passed to lit in the postcommit CI. |
Arc runner is down, I've reported it. |
DG2 tests for block_store, I ran tests manually on PVC Linux and DG2 Linux/Windows
The SLM accessor tests fail everywhere on DG2 on both Linux and Windows, so I just disabled them directly because the runtime driver check ends up being complicated, and none of the drivers, not even bleeding edge, work. I will file an internal bug for this.