Skip to content

[SYCL][ESIMD][E2E] Add DG2 unified memory block_store tests #12100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Dec 6, 2023

DG2 tests for block_store, I ran tests manually on PVC Linux and DG2 Linux/Windows

The SLM accessor tests fail everywhere on DG2 on both Linux and Windows, so I just disabled them directly because the runtime driver check ends up being complicated, and none of the drivers, not even bleeding edge, work. I will file an internal bug for this.

Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex marked this pull request as ready for review December 7, 2023 15:04
@sarnex sarnex requested a review from a team as a code owner December 7, 2023 15:04
@@ -5,6 +5,9 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//==----------------------------------------------------------==//
// TODO: Enable after driver bug is fixed
// XFAIL: gpu-intel-dg2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR, such params are not set in SYCLOS. gpu-intel-dg2 is always false there.
Perhaps, something in SYCLOS CI has changed and param is set - let's see how Intel Arg CI bot runs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think you are right, I think this will fail in postcomit.

It seems we set gpu-intel-dg2=True for the precommit Arc Matrix test job, but not for postcommit. I'll try to fix the CI before merging this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was wrong. We do set it for postcommit here. I think this PR is safe to merge.

@sarnex
Copy link
Contributor Author

sarnex commented Dec 7, 2023

@intel/llvm-gatekeepers Can we merge this one? It The Arc precommit job won't run the new tests added here anyway, they will only run in postcommit and I am convinced it will pass based on local testing and checking the flags passed to lit in the postcommit CI.

@aelovikov-intel
Copy link
Contributor

Arc runner is down, I've reported it.

@aelovikov-intel aelovikov-intel merged commit 19c17e2 into intel:sycl Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants