[Driver][SYCL][clang-linker-wrapper] Fix sycl device library arguments #12116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we use `--`, but in clang-linker-wrapper we use the Clang Arg infrastrcture to match them, and that requires `-`. At least for me every invocation of SYCL with the new offload model hits this problem. After this, at least clang-linker-wrapper finishes and we get some sycl-post-link error. Signed-off-by: Sarnie, Nick <[email protected]>
|
@mdtoguchi Mind taking a look at this bad boy when you have a sec? Thanks! |
|
@intel/llvm-gatekeepers This one is ready, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we use
--, but inclang-linker-wrapperwe use the clang Arg infrastructure to match them, and that requires-.At least for me every invocation of SYCL with the new offload model hits this problem. After this, at least
clang-linker-wrappergets further and we get somesycl-post-linkerror which I'll look at next.