[ESIMD][NFC] Remove some unused HOST code #12122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
v-klochkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Klochkov, Vyacheslav N <[email protected]>
v-klochkov
force-pushed
the
esimd_host_code_removal_nfc
branch
from
9ebf9c4 to
d1eb2e4
Compare
v-klochkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
v-klochkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
v-klochkov
changed the title
sarnex
approved these changes
Dec 8, 2023
| #define __ESIMD_INTRIN_END ; | ||
| #else | ||
| #define __ESIMD_INTRIN_END \ | ||
| { __ESIMD_UNSUPPORTED_ON_HOST; } |
There was a problem hiding this comment.
Looks like you beat me to this one, nice!
There was a problem hiding this comment.
There are still many intrinsics not using this new __ESIMD_INTRIN_END macro yet.
This macro was convenient for this mini clean-up fix.
There was a problem hiding this comment.
Ah ok nice, I will use the internal tracker assigned to me to port the rest of them to the macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is cascade removal of some unused code after removing esimd/detail/host_util.hpp and removing __ESIMD_EMU_DNS namespace.
Even with this change ESIMD headers still have lots of unused HOST-only code.