[UR] Document how to customize HIP directories #12127

jchlanda · 2023-12-08T13:05:56Z

No description provided.

jchlanda · 2023-12-14T11:43:04Z

Corresponding change in UR: oneapi-src/unified-runtime#1170

sycl/plugins/unified_runtime/CMakeLists.txt

jchlanda · 2024-01-09T13:57:28Z

@kbenzie is there anything else that needs to be done for this (and oneapi-src/unified-runtime#1170) to go in?

kbenzie · 2024-01-09T14:01:09Z

@kbenzie is there anything else that needs to be done for this (and oneapi-src/unified-runtime#1170) to go in?

For this the last thing would be updating the UR tag once oneapi-src/unified-runtime#1170 is merged (I'll comment over there for next steps). I'll hold off approving this until that's done.

sycl/plugins/unified_runtime/CMakeLists.txt

jchlanda · 2024-01-10T15:04:38Z

@dpcpp-doc-reviewers @ldrumm is there anything else you'd like to see done for this patch? Thank you.

ldrumm

@ldrumm is there anything else you'd like to see done for this patch? Thank you.

Sorry. Missed this one. Looks good modulo minor nits.

sycl/doc/GetStartedGuide.md

sycl/plugins/hip/CMakeLists.txt

kbenzie · 2024-01-11T11:30:32Z

@intel/dpcpp-doc-reviewers please review, other UR changes are waiting on this.

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>

Co-authored-by: ldrumm <[email protected]>

sycl/doc/GetStartedGuide.md

steffenlarsen

LGTM!

jchlanda mentioned this pull request Dec 8, 2023

[HIP] Allow custom location of ROCm components oneapi-src/unified-runtime#1170

Merged

jchlanda had a problem deploying to WindowsCILock December 8, 2023 14:10 — with GitHub Actions Failure

jchlanda force-pushed the jakub/hip_custom_dirs branch from 03fd673 to d92633b Compare December 8, 2023 14:13

jchlanda temporarily deployed to WindowsCILock December 8, 2023 14:14 — with GitHub Actions Inactive

jchlanda temporarily deployed to WindowsCILock December 8, 2023 14:35 — with GitHub Actions Inactive

jchlanda force-pushed the jakub/hip_custom_dirs branch 2 times, most recently from 21a94c6 to 3cdbde4 Compare December 14, 2023 11:41

jchlanda temporarily deployed to WindowsCILock December 14, 2023 11:43 — with GitHub Actions Inactive

jchlanda marked this pull request as ready for review December 14, 2023 11:43

jchlanda requested review from a team as code owners December 14, 2023 11:43

martygrant approved these changes Dec 14, 2023

View reviewed changes

jchlanda temporarily deployed to WindowsCILock December 14, 2023 12:04 — with GitHub Actions Inactive

kbenzie reviewed Dec 14, 2023

View reviewed changes

sycl/plugins/unified_runtime/CMakeLists.txt Outdated Show resolved Hide resolved

jchlanda temporarily deployed to WindowsCILock December 14, 2023 13:37 — with GitHub Actions Inactive

jchlanda temporarily deployed to WindowsCILock December 14, 2023 13:58 — with GitHub Actions Inactive

jchlanda requested a review from kbenzie December 14, 2023 14:18

jchlanda temporarily deployed to WindowsCILock December 18, 2023 13:13 — with GitHub Actions Inactive

jchlanda temporarily deployed to WindowsCILock December 18, 2023 13:36 — with GitHub Actions Inactive

jchlanda requested a review from a team as a code owner December 19, 2023 11:38

jchlanda requested a review from ldrumm December 19, 2023 11:38

jchlanda force-pushed the jakub/hip_custom_dirs branch from 2c547d0 to 9d31976 Compare December 19, 2023 12:26

jchlanda temporarily deployed to WindowsCILock December 19, 2023 12:27 — with GitHub Actions Inactive

jchlanda temporarily deployed to WindowsCILock December 19, 2023 12:51 — with GitHub Actions Inactive

jchlanda force-pushed the jakub/hip_custom_dirs branch from 9d31976 to 3c7275a Compare January 9, 2024 10:21

jchlanda temporarily deployed to WindowsCILock January 9, 2024 10:23 — with GitHub Actions Inactive

jchlanda temporarily deployed to WindowsCILock January 9, 2024 10:46 — with GitHub Actions Inactive

kbenzie reviewed Jan 10, 2024

View reviewed changes

sycl/plugins/unified_runtime/CMakeLists.txt Outdated Show resolved Hide resolved

jchlanda force-pushed the jakub/hip_custom_dirs branch from 2b45041 to 37bd40f Compare January 10, 2024 15:02

jchlanda temporarily deployed to WindowsCILock January 10, 2024 15:02 — with GitHub Actions Inactive

ldrumm approved these changes Jan 10, 2024

View reviewed changes

sycl/doc/GetStartedGuide.md Outdated Show resolved Hide resolved

sycl/plugins/hip/CMakeLists.txt Outdated Show resolved Hide resolved

jchlanda temporarily deployed to WindowsCILock January 10, 2024 15:25 — with GitHub Actions Inactive

jchlanda had a problem deploying to WindowsCILock January 11, 2024 08:10 — with GitHub Actions Error

jchlanda temporarily deployed to WindowsCILock January 11, 2024 08:15 — with GitHub Actions Inactive

jchlanda temporarily deployed to WindowsCILock January 11, 2024 08:37 — with GitHub Actions Inactive

jchlanda and others added 9 commits January 11, 2024 06:35

[UR] Document how to customize HIP directories

328af3a

[UR] Add UR repo and tag

7926a50

Mention intel/llvm variables and point to UR ones

776ccff

Correct var names

49e71e8

move vars to plugins/hip

986e269

Update sycl/plugins/hip/CMakeLists.txt

9eb013f

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>

Update sycl/plugins/unified_runtime/CMakeLists.txt

927cf20

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>

Update sycl/doc/GetStartedGuide.md

5b9b999

Co-authored-by: ldrumm <[email protected]>

Quote expansions

8d0a9de

jchlanda force-pushed the jakub/hip_custom_dirs branch from 1989087 to 8d0a9de Compare January 11, 2024 11:35

jchlanda temporarily deployed to WindowsCILock January 11, 2024 11:36 — with GitHub Actions Inactive

jchlanda had a problem deploying to WindowsCILock January 11, 2024 11:59 — with GitHub Actions Error

steffenlarsen reviewed Jan 11, 2024

View reviewed changes

sycl/doc/GetStartedGuide.md Outdated Show resolved Hide resolved

Wording

f0de0f3

jchlanda temporarily deployed to WindowsCILock January 11, 2024 12:30 — with GitHub Actions Inactive

jchlanda temporarily deployed to WindowsCILock January 11, 2024 13:03 — with GitHub Actions Inactive

steffenlarsen approved these changes Jan 11, 2024

View reviewed changes

steffenlarsen merged commit 8aa2b61 into intel:sycl Jan 11, 2024

jchlanda mentioned this pull request Jan 12, 2024

[HIP][Regression] Cannot override ROCm include and library paths #11873

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[UR] Document how to customize HIP directories #12127

[UR] Document how to customize HIP directories #12127

Uh oh!

jchlanda commented Dec 8, 2023

Uh oh!

jchlanda commented Dec 14, 2023

Uh oh!

Uh oh!

jchlanda commented Jan 9, 2024

Uh oh!

kbenzie commented Jan 9, 2024

Uh oh!

Uh oh!

jchlanda commented Jan 10, 2024

Uh oh!

ldrumm left a comment

Uh oh!

Uh oh!

Uh oh!

kbenzie commented Jan 11, 2024

Uh oh!

Uh oh!

steffenlarsen left a comment

Uh oh!

Uh oh!

[UR] Document how to customize HIP directories #12127

[UR] Document how to customize HIP directories #12127

Uh oh!

Conversation

jchlanda commented Dec 8, 2023

Uh oh!

jchlanda commented Dec 14, 2023

Uh oh!

Uh oh!

jchlanda commented Jan 9, 2024

Uh oh!

kbenzie commented Jan 9, 2024

Uh oh!

Uh oh!

jchlanda commented Jan 10, 2024

Uh oh!

ldrumm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kbenzie commented Jan 11, 2024

Uh oh!

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!