Skip to content

[SYCL][NFC] Remove item dependency on reduction. #12135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

bader
Copy link
Contributor

@bader bader commented Dec 9, 2023

Use Builder::createItem help function to create item object instead of
adding one helper function in reduction namespace.

Use Builder::createItem help function to create `item` object instead of
adding one helper function in reduction namespace.
@bader bader requested a review from a team as a code owner December 9, 2023 02:05
@bader bader requested a review from steffenlarsen December 9, 2023 02:05
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me! Tag @aelovikov-intel

@aelovikov-intel aelovikov-intel merged commit 8074617 into intel:sycl Dec 11, 2023
@bader bader deleted the reduction-dep branch July 11, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants