[HIP] Changes for device_globals and enable tests

[hdelan]

Enable device_global for AMDGPU. Related to oneapi-src/unified-runtime#1186 .

In order for hipModuleGetGlobal to see a global symbol we need to not make the visibility of the symbol hidden. Perhaps changing this as a default is not always a good idea. Could also do this in the SYCL headers using an attribute to specify the visibility of the device_global var

[steffenlarsen]

Very nice! I'm glad to see the program-metadata approach not being too much of a pain to include into the HIP backend. Thank you, @hdelan !

[jinz2014]

I have a question. Does hipcc see a global symbol by making visibility of symbols ? Thanks.

[hdelan]

I have a question. Does hipcc see a global symbol by making visibility of symbols ? Thanks.

Hi @jinz2014 it seems that HIPCC gives device globals protected visibility in the resulting binary.

[aarongreig]

update the tag and we're good to go @hdelan

[hdelan]

update the tag and we're good to go @hdelan

Thanks @aarongreig ! Have updated

[aarongreig]

ah might have been too quick on the draw from #12381 merging you'll need to resolve the conflict

[hdelan]

ah might have been too quick on the draw from #12381 merging you'll need to resolve the conflict

Yep just resolved. Will need to wait for pipeline I imagine

[kbenzie]

@intel/dpcpp-clang-driver-reviewers please review

[hdelan]

@steffenlarsen we are blocked here awaiting @intel/dpcpp-clang-driver-reviewers . Quite a small group and it seems they are off atm. What should we do here?

[steffenlarsen]

I believe they should be back today. Tag @mdtoguchi.

If I am wrong, I think we can merge and allow for a post-commit review if needed, though the driver changes don't seem so intrusive to me. Let's give it another day though.

[mdtoguchi]

Driver changes are OK - could you add some LIT testing to verify the additional option passing to sycl-post-link and compile step?

[hdelan]

Thanks @mdtoguchi have added a test for driver

[mdtoguchi]

LGTM - thanks!

[kbenzie]

@intel/llvm-gatekeepers please merge