[SYCL][Fusion] Error if fusion unsupported on device #12171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kernel fusion is currently not supported for SYCL devices of device type accelerator, as devices such as FPGAs do not support JIT compilation at runtime. Mark all end-to-end tests related to kernel fusion as unsupported for devices of type accelerator. Also use the newly created file to make the fact that kernel fusion is currently unsupported on Windows more explicit. Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jopperm
approved these changes
Dec 14, 2023
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
changed the title
jopperm
approved these changes
Dec 14, 2023
sommerlukas
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Refine fusion device info to not report support for accelerator devices on the OpenCL backend. Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dm-vodopyanov
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel fusion extension document says that an error will be thrown if a
queueis constructed withsycl::ext::codeplay::experimental::property::queue::enable_fusion, but the underlying device does not support fusion (i.e., returns false forget_info<sycl::ext::codeplay::experimental::info::device::supports_fusion>()). This change implements this behavior.Also, kernel fusion is currently not supported for SYCL devices of device type accelerator, as devices such as FPGAs do not support JIT compilation at runtime. Therefore, mark all end-to-end tests related to kernel fusion as unsupported for devices of type accelerator.
In addition, use the newly created file to make the fact that kernel fusion is currently unsupported on Windows more explicit.