[SYCL][NATIVECPU]Rename ext_native_cpu to ext_oneapi_native_cpu #12187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
changed the title
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sycl/include/sycl/backend_types.hpp
Outdated
| @@ -56,7 +56,7 @@ inline std::ostream &operator<<(std::ostream &Out, backend be) { | |||
| case backend::ext_oneapi_hip: | |||
| Out << "ext_oneapi_hip"; | |||
| break; | |||
| case backend::ext_native_cpu: | |||
| case backend::ext_oneapi_native_cpu: | |||
| Out << "ext_native_cpu"; | |||
There was a problem hiding this comment.
This needs to be changed as well. It will modify sycl-ls output but that would be a separate bugfix, not necessarily made in this area of the code.
There was a problem hiding this comment.
Thanks for pointing this out, I've made the change, I don't think the output of sycl-ls is used anywhere right now for native cpu
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
ext_native_cpubackend type toext_oneapi_native_cpu, making it conformant to the SYCL specification.