[SYCL][Fusion][NoSTL] Hide JITContext behind interface #12189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Oppermann <[email protected]>
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
reviewed
Dec 15, 2023
sommerlukas
approved these changes
Dec 18, 2023
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers Can you merge this, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allocate the
JITContextin thejit_compilerclass; instead make it an independent singleton inside the kernel fusion library.This PR is the start of a series of changes to remove uses of STL classes in the kernel fusion interface to prevent ABI issues in the future.