Skip to content

Avoid sema error in test case #12197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Avoid sema error in test case #12197

merged 1 commit into from
Dec 21, 2023

Conversation

XinWang10
Copy link
Contributor

@XinWang10 XinWang10 commented Dec 18, 2023

This patch llvm/llvm-project#75332 would report narrowing conversions with const references, which could lead to "error: constant expression evaluates to 2 which cannot be narrowed to type 'bool'".

@XinWang10 XinWang10 requested a review from a team as a code owner December 18, 2023 08:57
@XinWang10 XinWang10 requested review from bso-intel and jsji and removed request for a team December 18, 2023 08:57
Copy link
Contributor

@jsji jsji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@jsji jsji merged commit b551a58 into intel:sycl-web Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants