[SYCL][ESIMD] Remove use of is_pointer in the API declarations #12206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fineg74
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fineg74
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
v-klochkov
approved these changes
Dec 19, 2023
v-klochkov
reviewed
Dec 19, 2023
Comment on lines
3213
to
3214
| (is_rw_device_accessor_v<AccessorTy> || | ||
| is_rw_local_accessor_v<AccessorTy>), |
There was a problem hiding this comment.
Suggested change
| (is_rw_device_accessor_v<AccessorTy> || | |
| is_rw_local_accessor_v<AccessorTy>), | |
| (__ESIMD_DNS::is_rw_device_accessor_v<AccessorTy> || | |
| __ESIMD_DNS::is_rw_local_accessor_v<AccessorTy>), |
fineg74
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sarnex
approved these changes
Dec 19, 2023
v-klochkov
reviewed
Dec 19, 2023
| ESIMD_INLINE ESIMD_NODEBUG std::enable_if_t< | ||
| (sizeof(T) <= 4) && (N == 1 || N == 8 || N == 16 || N == 32) && | ||
| (std::is_same_v<detail::LocalAccessorMarker, AccessorTy> || | ||
| detail::is_accessor_with_v<AccessorTy, |
There was a problem hiding this comment.
minor comment: detail:: is redundant here. scatter_impl function is already inside detail namespace.
fineg74
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fineg74
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fineg74
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.