Correct some cuda/sycl accuracy from 0.0 to 0.5 and add relate handling. #12213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several functions for "sycl" and "cuda" requires "0.5" accuracy levels, which means correctly rounded results. For now x86 host AltMathLibrary doesn't have such ability. For such accuracy level, the fpbuiltins should be replaced by equivalent IR operation or llvmbuiltins.
FreddyLeaf
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
FreddyLeaf
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
ping for review |
premanandrao
approved these changes
Dec 21, 2023
smanna12
approved these changes
Dec 21, 2023
|
Thanks for review @premanandrao @andykaylor |
|
ping for review @intel/dpcpp-tools-reviewers |
1 similar comment
|
ping for review @intel/dpcpp-tools-reviewers |
AlexeySachkov
approved these changes
Jan 17, 2024
|
@intel/llvm-gatekeepers, this seems to be ready to land. Any objections to merge? |
asudarsa
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several functions for "sycl" and "cuda" requires "0.5" accuracy levels, which means correctly rounded results. For now x86 host AltMathLibrary doesn't have such ability. For such accuracy level, the fpbuiltins should be replaced by equivalent IR operation or llvmbuiltins.