[SYCL][Fusion] Require feature for all fusion tests #12216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even fusion end-to-end tests that do not require `complete_fusion` would fail if the tests are executed on a device that supports fusion in principle (e.g., CPU), but the build has fusion disabled. Require the `fusion` feature for all end-to-end tests in the fusion directory. Signed-off-by: Lukas Sommer <[email protected]>
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
approved these changes
Dec 20, 2023
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers This PR is ready to be merged, can someone merge please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even fusion end-to-end tests that do not require
complete_fusionwould fail if the tests are executed on a device that supports fusion in principle (e.g., CPU), but the build has fusion disabled.This change simply replaces the
REQUIRES: fusionin individual test files with the equivalent in thelit.local.cfgto require thefusionfeature for all tests in the directory.