[SYCL] Add missing fabs #12218
Merged
[SYCL] Add missing fabs #12218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdelan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
I have a question. Are the functions specific to Nvidia compilation ? Thanks. |
|
The symbol is mostly needed for NVidia compilation. Other triples might have |
hdelan
force-pushed
the
add-missing-fabs
branch
from
302eda0 to
50bd01d
Compare
hdelan
force-pushed
the
add-missing-fabs
branch
from
50bd01d to
79e6996
Compare
|
Friendly ping @dm-vodopyanov |
|
Friendly ping @intel/llvm-reviewers-runtime can I get a review on this please? |
|
Thanks @steffenlarsen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fabswas missing for Nvidia compilation