Skip to content

[SYCL][Driver] Fix problem with -foffload-static-lib with a source file #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2020

Conversation

mdtoguchi
Copy link
Contributor

When compiling from source and using -foffload-static-lib, the host object
was not being added to the partial link step. This looks to be a regression
from the -foffload-whole-static-lib update.

Signed-off-by: Michael D Toguchi [email protected]

Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the regressing commit hash to the message? Is it 360b25b that's in question?

Also, could you please explain the logic changes that brought about the regression? I'm failing to figure it out myself from the code of either commit :(

@mdtoguchi
Copy link
Contributor Author

Could you please add the regressing commit hash to the message? Is it 360b25b that's in question?

Also, could you please explain the logic changes that brought about the regression? I'm failing to figure it out myself from the code of either commit :(

I'll update the message with the regressing commit. Yes 360b25b is the culprit.

The logic changes involved improvements on what items should be sent to the linker and what should be sent to the unbundler. We no longer had to send values to either the linker or the unbundler as we now send to both. This ended up restricting the objects created from source from being sent to the unbundler and only to the linker.

When compiling from source and using -foffload-static-lib, the host object
was not being added to the partial link step.  This looks to be a regression
from the -foffload-whole-static-lib update.

Fixes regression from: 360b25b

Signed-off-by: Michael D Toguchi <[email protected]>
@mdtoguchi mdtoguchi force-pushed the private/mdtoguchi/static-lib-source-fix branch from 0aae7f8 to a9d5dfe Compare March 5, 2020 21:47
@AGindinson
Copy link
Contributor

The logic changes involved improvements on what items should be sent to the linker and what should be sent to the unbundler. We no longer had to send values to either the linker or the unbundler as we now send to both. This ended up restricting the objects created from source from being sent to the unbundler and only to the linker.

Thanks for clarifying this!

@bader bader merged commit 1a951cb into intel:sycl Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants