[SYCL][hip] Fix HSA headers lookup #12234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROCm installations prior to v6 don't respect the traditional installation layout and install the HSA headers to `$PREFIX/hsa/include/hsa` whereas in rocm6 it looks like they're putting it in the right place at `$PREFIX/include/hsa`. That cleanup from AMD is good news, but it means that our workarounds now break and we need to check both places. This is a companion to oneapi-src/unified-runtime#1208
|
FYI: I'm not really sure why this logic needs to be duplicated in both PI and UR. Is there a need for the HIP search logic to exist here now UR should handle plugings? |
GeorgeWeb
approved these changes
Dec 21, 2023
jchlanda
approved these changes
Dec 22, 2023
againull
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROCm installations prior to v6 don't respect the traditional installation layout and install the HSA headers to
$PREFIX/hsa/include/hsawhereas in rocm6 it looks like they're putting it in the right place at$PREFIX/include/hsa.That cleanup from AMD is good news, but it means that our workarounds now break and we need to check both places.
This is a companion to
oneapi-src/unified-runtime#1208