Skip to content

[NFC][SYCL] Re-format python files using "black" #12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

aelovikov-intel
Copy link
Contributor

#12184 enable format check for python files but we never properly formatted them. Do it now.

intel#12184 enable format check for python
files but we never properly formatted them. Do it now.
Copy link
Contributor

github-actions bot commented Dec 22, 2023

✅ With the latest revision this PR passed the Python code formatter.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl/doc/conf.py changes look good to me.

Please, fix pre-commit checks.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am personally a little on the fence regarding Python formatters, but consistency is nice. Should we have a comment at the top of each of these files encouraging the use of the formatter?

@aelovikov-intel
Copy link
Contributor Author

I am personally a little on the fence regarding Python formatters, but consistency is nice. Should we have a comment at the top of each of these files encouraging the use of the formatter?

Not necessary - pre-commit formatting check would just fail if it's not properly formatted.

@steffenlarsen
Copy link
Contributor

Not necessary - pre-commit formatting check would just fail if it's not properly formatted.

Ah, so it is part of the new formatting check? Great, then disregard the concern! 😄

@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Jan 2, 2024

@intel/unified-runtime-reviewers, ping.

@aelovikov-intel
Copy link
Contributor Author

@intel/unified-runtime-reviewers, ping x2.

Copy link
Contributor

@fabiomestre fabiomestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl/plugin changes LGTM

@steffenlarsen steffenlarsen merged commit 9ddb6d1 into intel:sycl Jan 4, 2024
@aelovikov-intel aelovikov-intel deleted the format-python branch January 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants