-
Notifications
You must be signed in to change notification settings - Fork 787
[NFC][SYCL] Re-format python files using "black" #12240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
intel#12184 enable format check for python files but we never properly formatted them. Do it now.
6db74fe
to
c02014f
Compare
✅ With the latest revision this PR passed the Python code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sycl/doc/conf.py changes look good to me.
Please, fix pre-commit checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am personally a little on the fence regarding Python formatters, but consistency is nice. Should we have a comment at the top of each of these files encouraging the use of the formatter?
Not necessary - pre-commit formatting check would just fail if it's not properly formatted. |
Ah, so it is part of the new formatting check? Great, then disregard the concern! 😄 |
@intel/unified-runtime-reviewers, ping. |
@intel/unified-runtime-reviewers, ping x2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sycl/plugin changes LGTM
#12184 enable format check for python files but we never properly formatted them. Do it now.