[SYCL][Driver] Set -aux-target-cpu for SYCL offload device compilation #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smanna12
force-pushed
the
private/smanna12/setauxtargetcpuondevice
branch
2 times, most recently
from
972e7f0 to
0ea2663
Compare
smanna12
changed the title
smanna12
changed the title
smanna12
changed the title
bader
reviewed
Mar 2, 2020
smanna12
force-pushed
the
private/smanna12/setauxtargetcpuondevice
branch
from
0ea2663 to
c0f857e
Compare
bader
reviewed
Mar 2, 2020
smanna12
force-pushed
the
private/smanna12/setauxtargetcpuondevice
branch
from
c0f857e to
6b2a7ff
Compare
|
@mdtoguchi could you please provide some feedback on the patches? |
mdtoguchi
reviewed
Mar 3, 2020
clang/test/Driver/sycl-offload.cpp
Outdated
| // CHECK-OFFLOAD: "-aux-target-cpu" "x86-64" | ||
| // CHECK-OFFLOAD: "-target-cpu" "x86-64" | ||
|
|
||
| /// Check "-aux-target-cpu" and "-target-cpu" are passed when compiling for SYCL offload device and host codes with enabling macros: |
There was a problem hiding this comment.
enabling macros has nothing to do with this check. Probably shouldn't be mentioned.
There was a problem hiding this comment.
Thanks @mdtoguchi for the feedback. I have updated the patch.
smanna12
force-pushed
the
private/smanna12/setauxtargetcpuondevice
branch
from
6b2a7ff to
b9ad657
Compare
mdtoguchi
reviewed
Mar 3, 2020
clang/test/Driver/sycl-offload.cpp
Outdated
| // CHECK-OFFLOAD: "-aux-target-cpu" "x86-64" | ||
| // CHECK-OFFLOAD: "-target-cpu" "x86-64" | ||
|
|
||
| /// Check "-aux-target-cpu" and "-target-cpu" are passed when compiling for SYCL offload device and host codes: |
There was a problem hiding this comment.
One more nit: You are also checking for feature here, so adding that in the comment would reduce confusion from the first check which uses the same comment.
There was a problem hiding this comment.
Thanks @mdtoguchi. I have updated comments.
bader
reviewed
Mar 3, 2020
smanna12
force-pushed
the
private/smanna12/setauxtargetcpuondevice
branch
from
b9ad657 to
6e4827d
Compare
This patch adds -aux_target_cpu that will set AVX and other necessary macros for the SYCL offload device compilation based on -aux-target-cpu target. Signed-off-by: Soumi Manna <[email protected]>
smanna12
force-pushed
the
private/smanna12/setauxtargetcpuondevice
branch
from
6e4827d to
fc0d87d
Compare
mdtoguchi
approved these changes
Mar 4, 2020
|
Thanks @mdtoguchi. @bader I have updated lit test to fix errors for "check-clang" build that happened with my previous patch. |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 5, 2020
…_accessor_refactor * origin/sycl: (38 commits) [SYCL] Fix device::get_devices() with a non-host device type (intel#1235) [SYCL][PI][CUDA] Implement kernel and kernel-group information queries (intel#1180) [SYCL] Remove default error code value in exception (intel#1150) [SYCL] Fix devicelib assert LIT test (intel#1245) [SYCL] Set aux-target-cpu for SYCL offload device compilation (intel#1225) [SYCL] Remove fabs and ceil from the list of unsupported math functions (intel#1217) [SYCL] Fix circular reference between events and queues (intel#1226) [CI][Doc] Use SSH to deploy GitHub Pages (intel#1232) [SYCL][CUDA][Test] Testing for use of CUDA primary context (intel#1174) [SYCL] allow underscore symbol in temporary directory name [SYCL] Reject zero length arrays (intel#1153) [SYCL] Fix static code analyzis concerns (intel#1189) [SYCL] Add more details about the -fintelfpga option (intel#1218) [SYCL][CUDA] Select only NVPTX64 device binaries (intel#1223) [SYCL] Reverse max work-group size order (intel#1177) [SYCL][Doc] Add GroupAlgorithms extension (intel#1079) [SYCL] Fix SYCL internal enumerators conflict with user defined macro (intel#1188) [SYCL][CUDA] Fixes context release and unnamed context scope (intel#1207) [SYCL][CUDA] Fix context creation property parsing [CUDA][PI] clang-format pi.h ...
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 5, 2020
…ctor_tests * origin/sycl: [SYCL] Fix device::get_devices() with a non-host device type (intel#1235) [SYCL][PI][CUDA] Implement kernel and kernel-group information queries (intel#1180) [SYCL] Remove default error code value in exception (intel#1150) [SYCL] Fix devicelib assert LIT test (intel#1245) [SYCL] Set aux-target-cpu for SYCL offload device compilation (intel#1225) [SYCL] Remove fabs and ceil from the list of unsupported math functions (intel#1217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds -aux-target-cpu that will set AVX and other necessary macros
for the SYCL offload device compilation based on -aux-target-cpu target.
Signed-off-by: Soumi Manna [email protected]