Skip to content

[SYCL][Doc][Joint matrix] Joint matrix tf32 type spec restructuring #12276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 22, 2024
Merged

[SYCL][Doc][Joint matrix] Joint matrix tf32 type spec restructuring #12276

merged 5 commits into from
Jan 22, 2024

Conversation

dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented Jan 2, 2024

No description provided.

@dkhaldi dkhaldi requested a review from a team as a code owner January 2, 2024 21:30
@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jan 3, 2024

@gmlueck, I addressed your feedback in the syclos PR so we can have a clean version with just tf32 here.
Did I capture everything right?

@dkhaldi dkhaldi mentioned this pull request Jan 5, 2024
Merged
@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jan 17, 2024 •
edited
Loading

Gentle ping for @gmlueck:

I addressed your feedback in the syclos PR so we can have a clean version with just tf32 here.
Did I capture everything right?

It will be good to merge this version here so we can add the other types in xmain.

gmlueck
gmlueck reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder and sorry for the delay. I think this looks good, but I have a comment about the examples below.

gmlueck
gmlueck reviewed Jan 19, 2024
View reviewed changes
sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc Outdated
bits of the value into the joint matrix or if it only writes the
relevant 19 bits.
==== copy
The template parameters `T1` and `T2` must use the abstract type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at your example, I think this wording could be improved. Note that the example shows a case when T2 is not an abstract type. Instead, I'd say it this way:

There is no special constraint for the joint_matrix_copy function. The template parameters T1 and T2 correspond to the element types of the src and dest matrices.

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jan 22, 2024

@intel/llvm-gatekeepers, all green, please merge.

@dm-vodopyanov
Copy link
Contributor

@dkhaldi please add tags to the PR title before merging

@dm-vodopyanov
Copy link
Contributor

dm-vodopyanov commented Jan 22, 2024 •
edited
Loading

+ specify the title, e.g. what spec, etc

@dkhaldi dkhaldi changed the title Spec restructuring [SYCL][Joint matrix] Joint matrix tf32 type spec restructuring Jan 22, 2024
@dm-vodopyanov dm-vodopyanov changed the title [SYCL][Joint matrix] Joint matrix tf32 type spec restructuring [SYCL][Doc][Joint matrix] Joint matrix tf32 type spec restructuring Jan 22, 2024
@dm-vodopyanov dm-vodopyanov merged commit 68f6d92 into intel:sycl Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlueck gmlueck gmlueck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkhaldi @dm-vodopyanov @gmlueck