[SYCL] Fix device selector bug introduced in #12288 #12328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The very last commit in that PR (intel@f9a1377) accidentally removed one condition needed to add the device into allowed devices list. Restore it here.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
reviewed
Jan 9, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Jan 9, 2024
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
commented
Jan 9, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
CUDA failure looks like some race condition in the CI itself, not a real failure for this PR. Previuos version passed at https://github.com/intel/llvm/actions/runs/7466771596. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The very last commit in #12288
(f9a1377) accidentally removed one condition needed to add the device into allowed devices list. Restore it here.