Skip to content

Fix hip memadvise events regression #12333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix hip memadvise events regression #12333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad8a6ff
Fix hip memadvise events regression
GeorgeWeb Jan 9, 2024
5033ef2
Clarify why the -996 errc is an acceptable result.
GeorgeWeb Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sycl/test-e2e/DiscardEvents/discard_events_usm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
// The test checks that the last parameter is `nullptr` for all PI calls that
// should discard events.
// {{0|0000000000000000}} is required for various output on Linux and Windows.
// NOTE: piextUSMEnqueuePrefetch and piextUSMEnqueueMemAdvise in the CUDA and
// HIP backends may return a warning result on Windows with error-code
// -996 (PI_ERROR_PLUGIN_SPECIFIC_ERROR) if USM managed memory is not
// supported or if unsupported advice flags are used for the latter API.
// Since it is a warning it is safe to ignore for this test.
//
// Everything that follows TestQueueOperations()
// CHECK: ---> piextUSMEnqueueMemset(
Expand All @@ -30,7 +35,7 @@
// CHECK-NEXT: pi_event * : {{0|0000000000000000}}[ nullptr ]
//
// CHECK: ---> piextUSMEnqueueMemAdvise(
// CHECK: ) ---> pi_result : PI_SUCCESS
// CHECK: ) ---> pi_result : {{PI_SUCCESS|-996}}
// CHECK-NEXT: [out]pi_event * : {{0|0000000000000000}}[ nullptr ]
//
// CHECK: ---> piEnqueueKernelLaunch(
Expand Down Expand Up @@ -75,7 +80,7 @@
// CHECK-NEXT: pi_event * : {{0|0000000000000000}}[ nullptr ]
//
// CHECK: ---> piextUSMEnqueueMemAdvise(
// CHECK: ) ---> pi_result : PI_SUCCESS
// CHECK: ) ---> pi_result : {{PI_SUCCESS|-996}}
// CHECK-NEXT: [out]pi_event * : {{0|0000000000000000}}[ nullptr ]
//
// CHECK: ---> piEnqueueKernelLaunch(
Expand Down
13 changes: 7 additions & 6 deletions sycl/test-e2e/DiscardEvents/discard_events_usm_ooo_queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
// The test checks that the last parameter is not `nullptr` for all PI calls
// that should discard events.
// {{0|0000000000000000}} is required for various output on Linux and Windows.
// NOTE: piextUSMEnqueuePrefetch in the CUDA backend may return a warning
// result on Windows with error-code -996
// (PI_ERROR_PLUGIN_SPECIFIC_ERROR). Since it is a warning it is safe to
// ignore for this test.
// NOTE: piextUSMEnqueuePrefetch and piextUSMEnqueueMemAdvise in the CUDA and
// HIP backends may return a warning result on Windows with error-code
// -996 (PI_ERROR_PLUGIN_SPECIFIC_ERROR) if USM managed memory is not
// supported or if unsupported advice flags are used for the latter API.
// Since it is a warning it is safe to ignore for this test.
//
// Everything that follows TestQueueOperations()
// CHECK: ---> piextUSMEnqueueMemset(
Expand Down Expand Up @@ -40,7 +41,7 @@
//
// CHECK: ---> piextUSMEnqueueMemAdvise(
// CHECK-NOT: pi_event * : {{0|0000000000000000}}[ nullptr ]
// CHECK: ---> pi_result : PI_SUCCESS
// CHECK: ---> pi_result : {{PI_SUCCESS|-996}}
//
// CHECK: ---> piEnqueueEventsWaitWithBarrier(
// CHECK-NOT: pi_event * : {{0|0000000000000000}}[ nullptr ]
Expand Down Expand Up @@ -97,7 +98,7 @@
//
// CHECK: ---> piextUSMEnqueueMemAdvise(
// CHECK-NOT: pi_event * : {{0|0000000000000000}}[ nullptr ]
// CHECK: ---> pi_result : PI_SUCCESS
// CHECK: ---> pi_result : {{PI_SUCCESS|-996}}
//
// CHECK: ---> piEnqueueEventsWaitWithBarrier(
// CHECK-NOT: pi_event * : {{0|0000000000000000}}[ nullptr ]
Expand Down