[SYCL][Doc] Fix spec for passing SPIRV struct args #12338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPIR-V modules may not contain a kernel argument of type **OpTypeStruct**. Structures are passed by reference, so the argument type is actually **OpTypePointer**. Also, slightly loosen the requirements for kernel arguments that are pointers. It is technically OK to pass any pointer, though only a USM pointer can be dereferenced in the kernel.
|
For more information on why this change is needed, see this comment. |
Pennycook
approved these changes
Jan 19, 2024
|
@intel/llvm-gatekeepers I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIR-V modules may not contain a kernel argument of type OpTypeStruct. Structures are passed by reference, so the argument type is actually OpTypePointer.
Also, slightly loosen the requirements for kernel arguments that are pointers. It is technically OK to pass any pointer, though only a USM pointer can be dereferenced in the kernel.