Skip to content

[DOC][SYCL][Graph] need warmup before recording if necessary #12357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

guoyejun
Copy link
Contributor

sometimes, the existing code does some extra work which should not be recorded, and so a warmup is needed for this case.

@guoyejun guoyejun requested a review from a team as a code owner January 11, 2024 07:32
sometimes, the existing code does some extra work which should not
be recorded, and so a warmup is needed for this case.
Copy link
Contributor

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition, this is valuable information but I'm not sure that this is the best place for it. This section is introducing the basic concepts of the API and this is a warning about a very specific usage "gotcha" to watch out for.

In general since the specification is a lengthy already due to the scope of the feature and the potential interactions, I'm wary of adding a lot of usage information like this to the spec. To me this risks both making the spec harder to consume, and making this information harder to find if buried amongst the spec. However, we have had discussions about creating a separate document(s) for more detailed usage information and examples like this.

I'll raise this idea again and see if we can get something set up to capture information like this.

@guoyejun
Copy link
Contributor Author

hope to see it soon, it is an important guideline for recording the function calls from libraries in the oneapi package such as onednn, onemkl, etc.

Copy link
Contributor

@reble reble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Bensuo by not adding such a guideline to the spec extension. From my perspective, a better place to put interactions with this extension listing workarounds and limitations could be a library documentation.

@guoyejun
Copy link
Contributor Author

It can be in the library doc at last, but before that, we need a place from sycl side for this guideline.

@EwanC
Copy link
Contributor

EwanC commented Aug 12, 2024

A usage guide was created in #14965 and this information added to it, so think this PR can be closed or modified to update the wording in that usage guide if it isn't sufficient.

@guoyejun guoyejun closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants