Skip to content

[SYCL][E2E] Introduce performance tests #12372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Jan 11, 2024

Just an additional directory under sycl/test-e2e that needs "llvm-lit
--param enable-perf-tests=1" to be executed and changes in post-commit
task to enable running those using a single worker and capturing output
even on PASSes.

I plan on modifying pre-commit to run the same given a label is provided
in a separate PR.

Better infrastructure, like using google benchmark or deeper integration
with CI, is not planned at the moment.

Copy link
Contributor

github-actions bot commented Jan 11, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@aelovikov-intel
Copy link
Contributor Author

Win failure

Failed Tests (1):
  Clang :: Format/clang-format-ignore.cpp

is unrelated and can be seen at https://github.com/intel/llvm/actions/runs/7494648608/job/20403025892 as well.

@aelovikov-intel aelovikov-intel merged commit 7af64df into intel:sycl Jan 12, 2024
@aelovikov-intel aelovikov-intel deleted the add-perf-tests branch January 12, 2024 19:35
aelovikov-intel added a commit that referenced this pull request Jan 17, 2024
Performance tests were added in #12372
to be executed in post-commit. This PR changes the pre-commit behavior.
The tests will run if either some performance test is modified (to keep
post-commit clean) or if `run-perf-tests` label is added to the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants