-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][E2E] Introduce performance tests #12372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ With the latest revision this PR passed the C/C++ code formatter. |
bb88bd0
to
f3f4f35
Compare
f3f4f35
to
fb2fb84
Compare
fb2fb84
to
9d0d113
Compare
9d0d113
to
776c21a
Compare
steffenlarsen
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
Win failure
is unrelated and can be seen at https://github.com/intel/llvm/actions/runs/7494648608/job/20403025892 as well. |
aelovikov-intel
added a commit
that referenced
this pull request
Jan 17, 2024
Performance tests were added in #12372 to be executed in post-commit. This PR changes the pre-commit behavior. The tests will run if either some performance test is modified (to keep post-commit clean) or if `run-perf-tests` label is added to the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an additional directory under sycl/test-e2e that needs "llvm-lit
--param enable-perf-tests=1" to be executed and changes in post-commit
task to enable running those using a single worker and capturing output
even on PASSes.
I plan on modifying pre-commit to run the same given a label is provided
in a separate PR.
Better infrastructure, like using google benchmark or deeper integration
with CI, is not planned at the moment.