[SYCL][Fusion][NoSTL] Simplify kernel attributes by making them less generic #12376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopperm
force-pushed
the
kf-nostl/attrs
branch
from
dc00c50 to
33a825f
Compare
jopperm
force-pushed
the
kf-nostl/attrs
branch
from
33a825f to
92fd2b7
Compare
jopperm
force-pushed
the
kf-nostl/attrs
branch
from
92fd2b7 to
e42af19
Compare
jopperm
commented
Jan 16, 2024
victor-eds
reviewed
Jan 16, 2024
…generic Signed-off-by: Julian Oppermann <[email protected]>
jopperm
force-pushed
the
kf-nostl/attrs
branch
from
e42af19 to
1bf9701
Compare
victor-eds
approved these changes
Jan 17, 2024
|
@intel/llvm-gatekeepers Could you merge this, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel attributes were previously modeled as an
std::stringname, and an arbitrarily longstd::vectorof string values, however we currently don't need this genericity to representreqd_work_group_sizeandwork_group_size_hintattributes. In fact, an attribute kind enum and anIndicesobject (= 3 integers) suffice.This PR is part of a series of changes to remove uses of STL classes in the kernel fusion interface to prevent ABI issues in the future.