Skip to content

[SYCL][E2E][Joint Matrix] Added -ffp-model=precise to some tests #12429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

YuriPlyakhin
Copy link
Contributor

Added -ffp-model=precise to joint_matrix_bf16_fill_k_cache tests as they do math with floating numbers and can get NaN result, which indicates error. Some compiler version may have different fp-model defaults, so this option make the test indipendent of compiler defaults.

Added -ffp-model=precise to joint_matrix_bf16_fill_k_cache tests
as the do math with floating numbers and can get NaN result,
which indicates error. Some compiler version may have different
fp-model defaults, so this option make the test indipendent of
compiler defaults.
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriPlyakhin
Copy link
Contributor Author

@intel/llvm-gatekeepers , all green. Please, merge

@aelovikov-intel aelovikov-intel merged commit aadd1e7 into intel:sycl Jan 18, 2024
@YuriPlyakhin YuriPlyakhin deleted the fix_flaky_joint_matrix_bf16_fill_k_cache branch January 18, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants