[UR] call urGetAdapter before creating a platform from native handle #12432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling urAdapterGet is required for the global adapter to be initialized, but it was missing when creating a platform from a native handle. This meant that the adapter's state never got initialized and its refcount remained at 0 (and overflowed on teardown). This had no visible side-effects until changes in intel#12403.
|
@intel/llvm-gatekeepers please merge. |
7 tasks
kbenzie
pushed a commit
that referenced
this pull request
Jan 22, 2024
…12432) Calling urAdapterGet is required for the global adapter to be initialized, but it was missing when creating a platform from a native handle. This meant that the adapter's state never got initialized and its refcount remained at 0 (and overflowed on teardown). This had no visible side-effects until changes in #12403.
pbalcer
added a commit
to pbalcer/llvm
that referenced
this pull request
Feb 6, 2024
This solves the same issues as intel#12432, but for urDeviceCreateWithNativeHandle.
nrspruit
pushed a commit
to nrspruit/llvm
that referenced
this pull request
Feb 6, 2024
This solves the same issues as intel#12432, but for urDeviceCreateWithNativeHandle. Includes required oneapi-src/unified-runtime#1252
ldrumm
pushed a commit
that referenced
this pull request
Feb 7, 2024
…12619) This solves the same issues as #12432, but for `urDeviceCreateWithNativeHandle`. I considered a more generalized solution (e.g., calling `urGetAdapter` in `piPluginInit`), but I'm not sure that's worth it considering PI is going away. All the other `CreateWithNativeHandle` functions require either platform or a device to already exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling urAdapterGet is required for the global adapter to be initialized, but it was missing when creating a platform from a native handle. This meant that the adapter's state never got initialized and its refcount remained at 0 (and overflowed on teardown).
This had no visible side-effects until changes in #12403.