Skip to content

[ESIMD][E2E] Disable N=non-power-of-two cases for slm_block_store() #12470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[ESIMD][E2E] Disable N=non-power-of-two cases for slm_block_store() #12470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sycl/test-e2e/ESIMD/unified_memory_api/Inputs/block_store.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,10 @@ bool test_block_store_slm(queue Q) {
//
// These test case may compute wrong values for some of elements
// if the driver is not new enough.
#if 0
// TODO: Enable these cases when GPU driver is fixed. It seems the issue with
// non-power-of-2 N values was resolved for slm_block_load(), but not for
// slm_block_store().
if (esimd_test::isGPUDriverGE(Q, esimd_test::GPUDriverOS::LinuxAndWindows,
"27556", "win.just.skip.test", false)) {
Passed &= testSLM<T, 3, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Expand All @@ -646,6 +650,7 @@ bool test_block_store_slm(queue Q) {
Passed &=
testSLM<T, 113, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
}
#endif

if constexpr (Features == TestFeatures::PVC ||
Features == TestFeatures::DG2) {
Expand Down Expand Up @@ -729,6 +734,10 @@ bool test_block_store_local_acc_slm(queue Q) {
//
// These test case may compute wrong values for some of elements
// if the driver is not new enough.
#if 0
// TODO: Enable these cases when GPU driver is fixed. It seems the issue with
// non-power-of-2 N values was resolved for slm_block_load(), but not for
// slm_block_store().
if (esimd_test::isGPUDriverGE(Q, esimd_test::GPUDriverOS::LinuxAndWindows,
"27556", "win.just.skip.test", false)) {
Passed &= testLocalAccSLM<T, 3, !CheckMask, CheckProperties>(
Expand All @@ -740,6 +749,7 @@ bool test_block_store_local_acc_slm(queue Q) {
Passed &= testLocalAccSLM<T, 113, !CheckMask, CheckProperties>(
Q, 2, AlignElemProps);
}
#endif

if constexpr (Features == TestFeatures::PVC ||
Features == TestFeatures::DG2) {
Expand Down