Skip to content

[SYCL][InvokeSimd][E2E] Enable uniform retval tests #12487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jan 24, 2024

They pass with the new driver.

@sarnex sarnex changed the title [SYCL][InvokeSimd][E2E] Enable uniform retval test [SYCL][InvokeSimd][E2E] Enable uniform retval tests Jan 24, 2024
@@ -1,6 +1,3 @@
// TODO: enable when Jira ticket resolved
// XFAIL: gpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid it will enable Win as well, and there was no update there. Need to wait for the CI to finish before merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't run these on Windows, see here

@sarnex sarnex marked this pull request as ready for review January 24, 2024 21:03
@sarnex sarnex requested a review from a team as a code owner January 24, 2024 21:03
@sarnex
Copy link
Contributor Author

sarnex commented Jan 24, 2024

Fails not related, it's from me destroying the repo in another commit :)

@sarnex sarnex merged commit f694c84 into intel:sycl Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants